Luxon #345
Luxon #345
Conversation
[docs] remove vertical scrollbar
setYear is missing the second argument
setYear was missing the second argument (year)
# Conflicts: # lib/src/typings/utils.d.ts # lib/src/utils/date-fns-utils.d.ts # lib/src/utils/moment-utils.d.ts
Fix missing argument for setYear in typings
Hm, that's weird. It runs fine on my machine. I need to set this environment variable for the localization. Luxon is using native Intl |
|
@lookapanda Can you please refer build failing and change your target branch to develop |
|
What do you mean by "refer build failing"? |
|
@lookapanda |
|
I was talking about the failing build. I don't know why the build fails, it runs locally. |
|
|
@lookapanda why does it need at all? |
|
Because I wanted to also test that the localization is properly working. |
|
I'm looking into this |
|
ok, tests are passing now |
|
Good job 👍 |
|
|
|
@lookapanda Oh, sorry, I was from phone and misslead that you backported master to your branch. Thanks for your work! |
| @@ -44,13 +44,15 @@ | |||
| }, | |||
| "dependencies": { | |||
| "babel-runtime": "^6.26.0", | |||
| "luxon": "^1.0.0", | |||
There was a problem hiding this comment.
hmm, shouldn't luxon be a dev dependency? And also be located in externalDependencies along with moment and date-fns?
There was a problem hiding this comment.
Jeez, yes, I totally forgot about that. I just ran yarn add luxon locally which adds that as a dependency automatically (like npm install --save. Yes, that should be changed.
There was a problem hiding this comment.
no worries ;)
would you like to submit a PR?
There was a problem hiding this comment.
Also, it would be great to document luxon localization on our docs page
There was a problem hiding this comment.
I just noticed that the performance with Luxon is not really that great compared to, for example, the DateFns util. I will investigate this later this week.
|
Okay, I investigated a bit about the performance. Any idea how we could improve the performance of As you can see, DateFns is much, much faster. There is nothing really one can do about that fact as It's very much noticeable when you open the date picker, for example. It takes some time until the modal opens. |
|
@lookapanda from a fast look, looks like There are two That being said, if poor performance is caused by Luxon itself - we have nothing to do with that. |
Issue #61
Description
As requested, here is the PR. I had to do some changes to package.json, I hope they are okay. All tests are still passing. Tell me if something needs to be changed.